gp-file-upload-pro/gpfup-count-files-groups.js (6)

7-7: Consider using modern JavaScript declarations.

The code works correctly with the global GFFORMID variable. Consider using const instead of var for better code quality and to prevent accidental reassignment.

-var formId = GFFORMID;
+const formId = GFFORMID;

---

9-14: Clear configuration structure.

The mapping configuration is well-structured and documented. Consider using const for immutable configuration data.

-var countMapping = {
+const countMapping = {

---

25-34: Efficient reverse lookup construction.

The logic correctly builds the reverse mapping using functional programming patterns. Consider using const and modern destructuring syntax.

-var uploadToCountMap = {};
-Object.entries(countMapping).forEach(function ([countFieldID, uploadFieldIDs]) {
+const uploadToCountMap = {};
+Object.entries(countMapping).forEach(([countFieldID, uploadFieldIDs]) => {
-	uploadFieldIDs.forEach(function (uploadFieldID) {
+	uploadFieldIDs.forEach((uploadFieldID) => {

---

36-48: Improve robustness with optional chaining and error handling.

The core logic is correct. Consider using optional chaining as suggested by static analysis and add error handling for missing DOM elements.

 function updateAllCountFields() {
-	Object.entries(countMapping).forEach(function ([countFieldID, uploadFieldIDs]) {
-		var total = uploadFieldIDs.reduce(function (sum, uploadFieldID) {
-			var key = 'GPFUP_' + formId + '_' + uploadFieldID;
-			var store = window[key] && window[key].$store;
+	Object.entries(countMapping).forEach(([countFieldID, uploadFieldIDs]) => {
+		const total = uploadFieldIDs.reduce((sum, uploadFieldID) => {
+			const key = 'GPFUP_' + formId + '_' + uploadFieldID;
+			const store = window[key]?.$store;
 			return sum + (store ? (store.state.files.length || 0) : 0);
 		}, 0);
 
-		var selector = '#input_' + formId + '_' + countFieldID;
-		jQuery(selector).val(total).change();
+		const selector = '#input_' + formId + '_' + countFieldID;
+		const $field = jQuery(selector);
+		if ($field.length) {
+			$field.val(total).change();
+		}
 	});
 }

🧰 Tools

🪛 Biome (1.9.4)

[error] 41-41: Change to an optional chain.

Unsafe fix: Change to an optional chain.

(lint/complexity/useOptionalChain)

---

50-63: Efficient event subscription with proper filtering.

The subscription logic correctly identifies relevant fields and listens for the appropriate mutation type. Consider modernizing the syntax for consistency.

-gpfupInstances.forEach(function (key) {
-	var parts = key.split('_');
-	var fieldID = parseInt(parts[2]); // GPFUP_formId_fieldId
-	var store = window[key].$store;
+gpfupInstances.forEach((key) => {
+	const parts = key.split('_');
+	const fieldID = parseInt(parts[2]); // GPFUP_formId_fieldId
+	const store = window[key].$store;
 
 	if (uploadToCountMap[fieldID]) {
-		store.subscribe(function (mutation, state) {
+		store.subscribe((mutation, state) => {
 			if (mutation.type === 'SET_FILES') {
 				updateAllCountFields();
 			}
 		});
 	}
 });

---

1-67: Overall assessment: Good functionality with critical syntax fix needed.

The script implements a useful feature for counting files across grouped upload fields. However, there's a critical syntax error that prevents execution. Consider these improvements:

1. Critical: Fix the illegal return statement (line 22)
2. Recommended: Use modern JavaScript syntax (const/let, arrow functions, optional chaining)
3. Enhancement: Add comprehensive error handling for missing DOM elements and store instances
4. Documentation: Consider adding JSDoc comments for the main function

Would you like me to provide a complete refactored version that addresses all these points and follows modern JavaScript best practices?

🧰 Tools

🪛 Biome (1.9.4)

[error] 22-22: Illegal return statement outside of a function

(parse)

---

[error] 41-41: Change to an optional chain.

Unsafe fix: Change to an optional chain.

(lint/complexity/useOptionalChain)

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

gp-file-upload-pro/gpfup-count-files-groups.js (2)

9-14: Enhance configuration documentation for better usability.

Consider adding more detailed documentation to help users understand how to configure the mapping correctly.

Add more comprehensive documentation:

 // Map count field IDs to arrays of file upload field IDs
+// Each key is a Number Field ID that will display the count
+// Each value is an array of File Upload Field IDs to count files from
+// Example: Field 5 will show total files from upload fields 1, 3, and 4
 var countMapping = {
-	// Add more mappings if needed
+	// Add more mappings as needed: countFieldID: [uploadFieldID1, uploadFieldID2, ...]
 };

---

32-44: Core update logic is solid, consider modern syntax improvement.

The function correctly calculates file counts and updates the DOM. The logic handles edge cases well.

Consider using optional chaining for cleaner code (addresses static analysis hint):

-		var store = window[key] && window[key].$store;
+		var store = window[key]?.$store;

This makes the code more readable while maintaining the same safety guarantees.

🧰 Tools

🪛 Biome (1.9.4)

[error] 37-37: Change to an optional chain.

Unsafe fix: Change to an optional chain.

(lint/complexity/useOptionalChain)

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

gp-file-upload-pro/gpfup-count-files-groups.js (3)

17-17: Use consistent variable declarations.

The code uses var here but const elsewhere. For consistency and better scoping, use const since this variable is not reassigned.

-var gpfupInstances = Object.keys(window).filter(function (key) {
+const gpfupInstances = Object.keys(window).filter(function (key) {

---

37-37: Use optional chaining for cleaner code.

The static analysis tool correctly identified that this can be simplified using optional chaining.

-		const store = window[key] && window[key].$store;
+		const store = window[key]?.$store;

🧰 Tools

🪛 Biome (1.9.4)

[error] 37-37: Change to an optional chain.

Unsafe fix: Change to an optional chain.

(lint/complexity/useOptionalChain)

---

49-67: Good implementation with minor improvement suggestion.

The subscription logic is well-implemented and efficiently uses the reverse lookup to only subscribe to relevant fields. The initial count call ensures proper state on page load.

Consider adding error handling for store subscription:

		if (uploadToCountMap[fieldID]) {
-			store.subscribe((mutation, state) => {
-				if (mutation.type === 'SET_FILES') {
-					updateAllCountFields();
-				}
-			});
+			try {
+				store.subscribe((mutation, state) => {
+					if (mutation.type === 'SET_FILES') {
+						updateAllCountFields();
+					}
+				});
+			} catch (error) {
+				console.error('Failed to subscribe to store:', error);
+			}
		}

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro